Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update indexmap requirement from 1 to 2 #1051

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Update indexmap requirement from 1 to 2 #1051

merged 2 commits into from
Jul 9, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2023

Updates the requirements on indexmap to permit the latest version.

Changelog

Sourced from indexmap's changelog.

  • 2.0.0

    • MSRV: Rust 1.64.0 or later is now required.

    • The "std" feature is no longer auto-detected. It is included in the default feature set, or else can be enabled like any other Cargo feature.

    • The "serde-1" feature has been removed, leaving just the optional "serde" dependency to be enabled like a feature itself.

    • IndexMap::get_index_mut now returns Option<(&K, &mut V)>, changing the key part from &mut K to &K. There is also a new alternative MutableKeys::get_index_mut2 to access the former behavior.

    • The new map::Slice<K, V> and set::Slice<T> offer a linear view of maps and sets, behaving a lot like normal [(K, V)] and [T] slices. Notably, comparison traits like Eq only consider items in order, rather than hash lookups, and slices even implement Hash.

    • IndexMap and IndexSet now have sort_by_cached_key and par_sort_by_cached_key methods which perform stable sorts in place using a key extraction function.

    • IndexMap and IndexSet now have reserve_exact, try_reserve, and try_reserve_exact methods that correspond to the same methods on Vec. However, exactness only applies to the direct capacity for items, while the raw hash table still follows its own rules for capacity and load factor.

    • The Equivalent trait is now re-exported from the equivalent crate, intended as a common base to allow types to work with multiple map types.

    • The hashbrown dependency has been updated to version 0.14.

    • The serde_seq module has been moved from the crate root to below the map module.

  • 1.9.3

    • Bump the rustc-rayon dependency, for compiler use only.

  • 1.9.2

    • IndexMap and IndexSet both implement arbitrary::Arbitrary<'_> and quickcheck::Arbitrary if those optional dependency features are enabled.

  • 1.9.1

    • The MSRV now allows Rust 1.56.0 as well. However, currently hashbrown 0.12.1 requires 1.56.1, so users on 1.56.0 should downgrade that to 0.12.0 until there is a later published version relaxing its requirement.

... (truncated)

Commits
  • 8e47be8 Merge pull request #267 from cuviper/release-2.0.0
  • ad694fb Release 2.0.0
  • b5b2814 Merge pull request #266 from cuviper/doc-capacity
  • d3ea289 Document the lower-bound semantics of capacity
  • 74e14da Merge pull request #264 from cuviper/equivalent
  • 677c605 Add a relnote for Equivalent
  • 6d83bc1 pub use equivalent::Equivalent;
  • bb48357 Merge pull request #263 from cuviper/insert_in_slot
  • c37dae6 Use hashbrown's new single-lookup insertion
  • ee71507 Merge pull request #262 from daxpedda/hashbrown-v0.14
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update indexmap requirement from 1 to 2
289f0aa 
Updates the requirements on [indexmap](https://github.com/bluss/indexmap) to permit the latest version.
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@1.0.0...2.0.0)

---
updated-dependencies:
- dependency-name: indexmap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies PRs updating dependencies (dependabot automation) label Jun 26, 2023
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdnative/pr-1051

@Bromeon
Copy link
Member

Bromeon commented Jun 26, 2023

bors try

bors bot added a commit that referenced this pull request Jun 26, 2023
@bors
Try #1051:
248ae6d
@bors
Copy link
Contributor

bors bot commented Jun 26, 2023

try

Build failed:

@chitoyuu
Copy link
Contributor

Again, it seems to be the iOS build failing to find a new version of a crate:

 [2023-06-26T07:37:47Z ERROR cargo_dinghy] failed to select a version for the requirement `hashbrown = "^0.14"`
    candidate versions found which didn't match: 0.13.2, 0.13.1, 0.12.3, ...
    location searched: crates.io index
    required by package `indexmap v2.0.0`
        ... which satisfies dependency `indexmap = "^2"` of package `gdnative-core v0.11.3 (/Users/runner/work/gdnative/gdnative/gdnative-core)`
        ... which satisfies path dependency `gdnative-core` of package `gdnative v0.11.3 (/Users/runner/work/gdnative/gdnative/gdnative)`

This seems to be a pattern seen with other recent dependabot PRs that failed, e.g. #1050

There do not seem to be any relevant issues in the cargo_dinghy repo, which does still seem to be maintained. We are using an older version 0.4.71 as opposed to the latest 0.6.4 though, which may or may not be relevant. Perhaps we should try bumping that first.

@chitoyuu
Copy link
Contributor

chitoyuu commented Jul 9, 2023

bors try

bors bot added a commit that referenced this pull request Jul 9, 2023
@bors
Try #1051:
6b24531
@chitoyuu
Copy link
Contributor

chitoyuu commented Jul 9, 2023

I'm not sure if it's the version bump or the delay, but the CI seems to pass now, so I'll merge this.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 717b8db into master Jul 9, 2023
@bors bors bot deleted the dependabot/cargo/indexmap-2 branch July 9, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies PRs updating dependencies (dependabot automation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GodotRust @Bromeon @chitoyuu